v0.4.2: switch wait/notify to busy wait

This solves a race condition, yes using lock/semaphore would do this too, but that is a considerable amount of complexity for what amounts to an extremely simple bit of blocking logic. busy-wait works just as well and is insignificantly more expensive with the use of thread.sleep.

core/src/main/java/com/shatteredpixel/shatteredpixeldungeon/actors/Actor.java

@@ -204,8 +204,11 @@ public abstract class Actor implements Bundlable {
 					// If it's character's turn to act, but its sprite
 					// is moving, wait till the movement is over
 					try {
-						synchronized (((Char)acting).sprite) {
+						//yes, we're busy-waiting. This is insignificantly slower than using
-							((Char) acting).sprite.wait();
+						//a lock/semaphore but results in more readable code.
+						while (((Char)acting).sprite.isMoving) {
+							//tries every ~0.1 milliseconds
+							Thread.sleep(0, 100000);
 						}
 					} catch (InterruptedException e) {
 						ShatteredPixelDungeon.reportException(e);

core/src/main/java/com/shatteredpixel/shatteredpixeldungeon/sprites/CharSprite.java

@@ -453,14 +453,11 @@ public class CharSprite extends MovieClip implements Tweener.Listener, MovieClip
 
 		} else if (tweener == motion) {
 
-			isMoving = false;
-			synchronized (this){
-				notify();
-			}
-
 			motion.killAndErase();
 			motion = null;
 			ch.onMotionComplete();
+
+			isMoving = false;
 		}
 	}
 

core/src/main/java/com/shatteredpixel/shatteredpixeldungeon/sprites/TenguSprite.java

@@ -102,11 +102,8 @@ public class TenguSprite extends MobSprite {
 	@Override
 	public void onComplete( Animation anim ) {
 		if (anim == run) {
-			isMoving = false;
-			synchronized (this){
-				notify();
-			}
 			idle();
+			isMoving = false;
 		} else {
 			super.onComplete( anim );
 		}